krampus/grunk
1
0
Fork 0
generated from krampus/template-godot4
Code Issues 68 Pull Requests Actions Packages Projects 1 Releases 6 Wiki Activity

Avoid extraneous settings writes from tutorial activation

Browse Source
This commit is contained in:
Rob Kelly 2025-07-10 17:56:33 -06:00
parent 7c63077312
commit 12fbc28f66
2 changed files with 7 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/game/tutorial/tutorial_manager/tutorial_manager_type.gd
View File

@ -7,8 +7,9 @@ const TUTORIAL_KEY_PREFIX := "game/tutorial/progress/"
func activate(key: String) -> void: func activate(key: String) -> void:
ProjectSettings.set_setting(key, true) if not is_active(key):
Game.settings.write() ProjectSettings.set_setting(key, true)
Game.settings.write()
func is_active(key: String) -> bool: func is_active(key: String) -> bool:
@ -45,6 +46,6 @@ func reset_tutorial() -> void:
func disable_tutorial() -> void: func disable_tutorial() -> void:
disable_all.emit() for key: String in get_tutorial_keys():
# XXX does this ensure the call to write will happen after all signals resolve? ProjectSettings.set_setting(key, true)
Game.settings.write.call_deferred() Game.settings.write()

2
src/props/retinal_scanner/retinal_scanner.gd
View File

@ -56,5 +56,5 @@ func deserialize(state: Dictionary) -> void:
func _process(_delta: float) -> void: func _process(_delta: float) -> void:
# TODO don't do this in _process # TODO donAAaaaa't do this in _process
interactive.enabled = enabled and _has_item() interactive.enabled = enabled and _has_item()